Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: frontend: do not compare non-semver tags to semver tags #1427

Merged
merged 1 commit into from
Feb 6, 2023
Merged

core: frontend: do not compare non-semver tags to semver tags #1427

merged 1 commit into from
Feb 6, 2023

Conversation

Williangalvani
Copy link
Member

fix #1423

joaoantoniocardoso
joaoantoniocardoso reviewed Feb 2, 2023
View reviewed changes
core/frontend/src/components/version-chooser/VersionChooser.vue
} catch {
// if we are on a random, non-SemVer tag, we cant compare it to a SemVer tag.
return ''
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler seems skeptical about the need for this try-catch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got rid of it

joaoantoniocardoso
joaoantoniocardoso approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and I can confirm that it solves the problem :)

just make the compiler happy and you're good to go

joaoantoniocardoso
joaoantoniocardoso requested changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is a missing detail here:

  • When we are at the latest master, the spinner keeps spinning forever
    image

@Williangalvani
Copy link
Member Author

updated and rebased, no spinner for me:
Screenshot 2023-02-02 at 12 27 56

joaoantoniocardoso
joaoantoniocardoso approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed :)

@joaoantoniocardoso joaoantoniocardoso merged commit 8056786 into bluerobotics:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version Chooser: can't update - "Invalid version: master"
3 participants
@Williangalvani @patrickelectric @joaoantoniocardoso