Add theme on top #1442
Merged
Add theme on top #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dark mode Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
ES-Alexander
reviewed
Feb 6, 2023
There was a problem hiding this comment.
I think the toggle is maybe the wrong way around, but it depends how you think about it.
In the docs when you're currently in dark mode it shows the sun, so you can click on it to get what you want. In this PR you've made it so that the icon shows what you're currently on, and you can click on that to change it to something else. Honestly not really sure what's better. I guess we can discuss in the meeting.
patrickelectric
force-pushed
the
add_theme-on-top
branch
from
1a97670
to
beea84f
Compare
|
@ES-Alexander just updated |
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
add_theme-on-top
branch
from
beea84f
to
ad6f347
Compare
|
@ES-Alexander that is consistent with the pirate mode behavior. Happy robot = Normal mode is On. Moon = Dark mode is On. |
|
@ES-Alexander I'm planning o create the next BlueOS release ASAP for the company meeting, so let me know what you think. |
ES-Alexander
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek.06-02-2023.12-50.mp4