Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the warning number from 36 to 22 #1453

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

patrickelectric
Copy link
Member

No description provided.

…to 22

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…PropType

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
We support any type

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Copy link
Member Author

patrickelectric commented Feb 8, 2023

The only warning messages are from MAVLink messages:

image

I'm planning to fix that properly soon.

Comment on lines +75 to 76
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const chart = this.$refs.chart as any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could define a Chart type to prevent using any

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I did try creating a d.ts but without luck, the typescript was just failing to find it at all.

@patrickelectric patrickelectric merged commit 7f3595d into bluerobotics:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants