Dialog parameter #1464
Dialog parameter #1464
Conversation
patrickelectric
force-pushed
the
dialog_parameter
branch
5 times, most recently
from
bfbe907
to
aa033f5
Compare
patrickelectric
force-pushed
the
dialog_parameter
branch
from
aa033f5
to
1c57fb7
Compare
core/frontend/src/components/parameter-editor/ParameterEditor.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This looks great - love it! :-)
Is the blinking reboot icon tied to pirate mode somehow, or are the pirate mode mentions in the tray menu stuff just to get the icon to show up in the header? The parameter editor is available in friendly mode, so the reboot icon should be too (it might already be fine) :-)
patrickelectric
force-pushed
the
dialog_parameter
branch
from
1c57fb7
to
ac69698
Compare
It was something that I did for internal test, forgot to remove it |
patrickelectric
force-pushed
the
dialog_parameter
branch
from
ac69698
to
6cc37fd
Compare
|
can you fix this issue? when we type a number it immediately switches to the option: Screen.Recording.2023-02-15.at.15.28.54.movit is pre-existent, but since you are working in this component =P |
…alog to new component Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…version Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Shift left creates wrong results for number over 30, exponencial is safer Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… equation Shift left creates wrong results for number over 30, exponencial is safer Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…eter modifier UI once custom input loses focus Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
dialog_parameter
branch
from
6cc37fd
to
c961a1f
Compare
|
@Williangalvani check now |
Lol, nice logic @Williangalvani - shame I didn't think to recommend #1210 at the same time... |
I'm not a fan of changing the scope of a PR since this can result on bigger changes and drag the PR merge time with it. That's one of the reasons that ArduPilot has a PR list hell. |
Move parameter dialog to its own component to be used in different places.
Also turns the
autopilot rebootbutton to be global, to follow the user between the pages until it's rebooted.Fix #1471