Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdp #1490

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Fix sdp #1490

merged 4 commits into from
Feb 17, 2023

Conversation

joaoantoniocardoso
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso commented Feb 17, 2023

Closes #1483 and fixes #1488

Before:

image

After:

image

</v-btn>
</template>
</v-simple-table>
<v-btn v-tooltip="'Copy to clipboard'" class="ma-1 elevation-1" small @click="copySDPFileURL">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy file URL to clipboard

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it's not clear if it's the URL or the file content that would be copied. Maybe also change the icon to this one?

image

@patrickelectric patrickelectric merged commit b243408 into bluerobotics:master Feb 17, 2023
@patrickelectric
Copy link
Member

Looks better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: video manager: SDP generation fails for Fake Source Expose the SDP download link
2 participants