core: frontend: Implement motor test #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
motortest
branch
2 times, most recently
from
7cefe49
to
9c42905
Compare
|
Williangalvani
force-pushed
the
motortest
branch
2 times, most recently
from
3179362
to
cc74bb4
Compare
|
we still need to able to revert the motor direction, along with a couple of other things. I intend to do this as it's own component in another pr |
Williangalvani
force-pushed
the
motortest
branch
from
cc74bb4
to
bdcc794
Compare
patrickelectric
requested changes
Mar 10, 2023
| }, | ||
| methods: { | ||
| styleForMotorBar(value: number): string { | ||
| const percent = (value - 1500) / 10 |
There was a problem hiding this comment.
Shouldn't be SERVOn_MIN and SERVOn_MAX ?
There was a problem hiding this comment.
motors don't use SERVOn_MIN/MAX
We can expose MOT_PWM_MIN/MAX in another slider, I think.
There was a problem hiding this comment.
there should probably at minimum be a TODO here on using TRIM params here, instead of hardcoded 1500
There was a problem hiding this comment.
we don't really have TRIM params for motors, though 😅
Williangalvani
force-pushed
the
motortest
branch
from
bdcc794
to
ef733ba
Compare
|
@Williangalvani can you rebase over master ? |
| command: { | ||
| type: MavCmd.MAV_CMD_COMPONENT_ARM_DISARM, | ||
| }, | ||
| target_system: 1, |
There was a problem hiding this comment.
That will be affect by #1581, do you prefer to merge it before ?
Williangalvani
force-pushed
the
motortest
branch
from
ef733ba
to
3ced98e
Compare
Williangalvani
force-pushed
the
motortest
branch
from
3ced98e
to
d110f40
Compare
patrickelectric
approved these changes
Apr 8, 2023
16 tasks
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs some cleaning up, and probably refactoring the the arm button into a component
tested with a servo in the pwm rail and 5v jumped to it