Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow download system log #1506

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Allow download system log #1506

merged 2 commits into from
Feb 21, 2023

Conversation

patrickelectric
Copy link
Member

Fix #1047

@patrickelectric
core: frontend: components: SettingsMenu: Add option to download log …
4fa8a5d 
…files

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: libs: filebrowser: Add function to download a folder
b93d0c1 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
joaoantoniocardoso
joaoantoniocardoso approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is about this:

image

@patrickelectric
Copy link
Member Author

That's how the filebrowser API works right now.

@patrickelectric patrickelectric merged commit 9233855 into bluerobotics:master Feb 21, 2023
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Mar 8, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Mar 9, 2023
@ES-Alexander
advanced-usage: settings: update image
9769681 
Documents:
- bluerobotics/BlueOS#1506
- bluerobotics/BlueOS#1507
patrickelectric pushed a commit to bluerobotics/ardusub-zola that referenced this pull request Mar 9, 2023
@ES-Alexander @patrickelectric
advanced-usage: settings: update image
779a51e 
Documents:
- bluerobotics/BlueOS#1506
- bluerobotics/BlueOS#1507
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Mar 9, 2023
patrickelectric pushed a commit to bluerobotics/ardusub-zola that referenced this pull request Mar 21, 2023
@ES-Alexander @patrickelectric
advanced-usage: settings: update image
bb55574 
Documents:
- bluerobotics/BlueOS#1506
- bluerobotics/BlueOS#1507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: frontend: Add page to download logs
3 participants
@patrickelectric @joaoantoniocardoso @ES-Alexander