-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: frontend: Change icon and tooltip for SDP URL copy button #1514
core: frontend: Change icon and tooltip for SDP URL copy button #1514
Conversation
joaoantoniocardoso
commented
Feb 23, 2023
I feel like content-copy makes more sense. I'm pretty sure I've seen it used for link plenty of times |
Icon names are not always the best guess for their use, but would the |
file-link makes more sense to me for this case, where it's a link for the file. |
@joaoantoniocardoso @Williangalvani what is the status of this PR ? |
@patrickelectric I was waiting for @Williangalvani to show examples or further reasoning against the icon change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Willian, if we were showing the file url here then I'd agree that content-copy
would make more sense (since there would be clear content being copied), but since it just says "File URL" with a download button then I think the file-link
makes more sense in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I dont have THAT strong feelings about this