Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting vehicle name and mDNS from the frontend #1582

Merged
merged 12 commits into from
Apr 21, 2023

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Apr 7, 2023

Screen.Recording.2023-04-07.at.16.38.18.mov

requires #1585

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Apr 8, 2023
@patrickelectric patrickelectric mentioned this pull request Apr 8, 2023
@patrickelectric
Copy link
Member

follows: #1511 (comment)

@Williangalvani
Copy link
Member Author

updates:

Screen.Recording.2023-04-09.at.00.24.58.mov

core/frontend/src/components/app/VehicleBanner.vue Outdated Show resolved Hide resolved
core/services/beacon/settings.py Outdated Show resolved Hide resolved
core/frontend/src/components/app/ImagePicker.vue Outdated Show resolved Hide resolved
core/frontend/src/components/app/ImagePicker.vue Outdated Show resolved Hide resolved
core/frontend/src/components/app/ImagePicker.vue Outdated Show resolved Hide resolved
core/frontend/src/components/app/ImagePicker.vue Outdated Show resolved Hide resolved
core/frontend/src/components/app/VehicleBanner.vue Outdated Show resolved Hide resolved
core/tools/nginx/nginx.conf Show resolved Hide resolved
core/tools/nginx/nginx.conf Outdated Show resolved Hide resolved
@patrickelectric
Copy link
Member

@Williangalvani it appears that has conflicts, can you rebase it ?

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's showing empty images and My Vehicle over BlueBoat to me.

image

image

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking on the vehicle name, it shows My Vehicle:

image

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both logo and vehicle are failing to upload new images.
"Click to upload an image or" .... ?
image

@Williangalvani
Copy link
Member Author

Both logo and vehicle are failing to upload new images. "Click to upload an image or" .... ? image

Can you check again?

@patrickelectric
Copy link
Member

@Williangalvani I'm getting the same error again

@Williangalvani
Copy link
Member Author

@patrickelectric I'm having a hard time replicating the issue. can you check the contents of /var/log/nginx/error.log?
try an upload while tail -f /var/log/nginx/error.log

I managed to replicate it earlier but I was getting a "permission denied" error 🤔

@patrickelectric
Copy link
Member

image

root@blueos:~# tail -f /var/log/nginx/error.log
2023/04/21 02:47:42 [error] 280#280: *4707 open() "/usr/blueos/userdata/images/logo" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/images/logo HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/tools/version-chooser"
2023/04/21 02:48:30 [error] 279#279: *4689 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/"
2023/04/21 02:48:35 [error] 279#279: *4670 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/"
2023/04/21 02:48:39 [error] 279#279: *4689 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/"
2023/04/21 02:48:43 [error] 279#279: *4983 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.86.46, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "blueos-avahi.local", referrer: "http://blueos-avahi.local/"
2023/04/21 02:48:52 [error] 279#279: *4980 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.86.46, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "blueos-avahi.local", referrer: "http://blueos-avahi.local/"
2023/04/21 02:49:01 [error] 280#280: *5027 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/"
2023/04/21 02:49:04 [error] 279#279: *4839 open() "/usr/blueos/userdata/styles/theme_style.css" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/styles/theme_style.css HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/"
2023/04/21 02:49:21 [crit] 279#279: *4670 mkdir() "/usr/blueos/userdata/images/vehicle/patrick.jpg" failed (13: Permission denied), client: 192.168.0.69, server: , request: "PUT /upload//userdata/images/vehicle/patrick.jpg HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/tools/web-terminal"
2023/04/21 02:49:21 [error] 280#280: *5027 open() "/usr/blueos/userdata/images/vehicle" failed (2: No such file or directory), client: 192.168.0.69, server: , request: "GET /userdata/images/vehicle HTTP/1.1", host: "192.168.0.46", referrer: "http://192.168.0.46/tools/web-terminal"

@Williangalvani
Copy link
Member Author

@patrickelectric patrickelectric merged commit 18b709d into bluerobotics:master Apr 21, 2023
5 checks passed
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants