New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: frontend: components: DHCPServerDialog: Fix if check #1595

Merged

Williangalvani merged 1 commit into bluerobotics:master from patrickelectric:fix-network-manager

Apr 9, 2023

Member

patrickelectric commented Apr 9, 2023

If was checking for something that does not exist, add correct computed method to check status


          core: frontend: components: DHCPServerDialog: Fix if check

72aae73

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

patrickelectric requested review from rafaellehmkuhl and Williangalvani

April 9, 2023 00:20

Williangalvani approved these changes

View reviewed changes

Member

Williangalvani left a comment

was CI no catching this? it even shows up red in vscode here, weird.

Williangalvani merged commit 9f608bb into bluerobotics:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment