Bag: Improve access #1602
Bag: Improve access #1602
Conversation
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
|
I'm a bit lost here. What/how is the |
payload is a json |
| if path == 'root': | ||
| current_data = payload | ||
| else: | ||
| dpath.new(current_data, path, payload, separator=".") | ||
| write_db(current_data) |
There was a problem hiding this comment.
So.. Here we are replacing the entire db without checking if its structure is correct. I can't evaluate the implications because I'm not aware of the rest of the code, I believe in your judgment
There was a problem hiding this comment.
like.. a write_data("/root", {}) call would erase the db
There was a problem hiding this comment.
like.. a
write_data("/root", {})call would erase the db
That's the point
There was a problem hiding this comment.
I have created an endpoint to only do that, making it more explicit
patrickelectric
force-pushed
the
bag-root
branch
2 times, most recently
from
c001ed8
to
7b059c0
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
bag-root
branch
2 times, most recently
from
a82df28
to
be91908
Compare
patrickelectric
force-pushed
the
bag-root
branch
from
be91908
to
41606db
Compare
core/services/bag_of_holding/main.py
Outdated
| current_data = read_db() | ||
| try: | ||
| result = dpath.get(current_data, path, separator=".") | ||
| result = dpath.util.search(current_data, path) |
There was a problem hiding this comment.
I'm not sure I like this, what is the purpose of using search? I think if we have something like
{
"potato: {
"a": 1,
"b": 2
}
}
and we ask for "potato/a" we should just get 1, instead I'm getting:
{
"potato: {
"a": 1
}
}
patrickelectric
force-pushed
the
bag-root
branch
from
41606db
to
81e3727
Compare
- Use '/' as separator - Allow usage of wildcard * to get everything - Create an endpoint to allow overwriting db Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
bag-root
branch
from
81e3727
to
3f212ba
Compare
No description provided.