Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bag editor #1603

Merged
merged 8 commits into from
Apr 21, 2023
Merged

Bag editor #1603

merged 8 commits into from
Apr 21, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Apr 11, 2023 •
edited

Peek 11-04-2023 10-25

@patrickelectric patrickelectric force-pushed the bag-editor branch 2 times, most recently from d763746 to 8c80ab5 Compare April 11, 2023 13:20
@patrickelectric patrickelectric marked this pull request as ready for review April 11, 2023 13:20
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Apr 11, 2023
@patrickelectric patrickelectric added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Apr 18, 2023
joaoantoniocardoso
joaoantoniocardoso approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickelectric
core: frontend: package: Add jsoneditor package
0836edb 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: App: Remove global scrollbar
46c69dd 
The content should have the scrollbar

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: menus: Add bag editor
fd91883 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: yarn: Update lock file
731c1da 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: router: Add BagEditorView
45e6c62 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: views: BagEditorView: First commit
892bc6c 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: store: bag: Add overwrite endpoint
0286f91 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: components: common: JsonEditor: First commit
fae7555 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric patrickelectric merged commit a8c5ccf into bluerobotics:master Apr 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickelectric @joaoantoniocardoso @ES-Alexander