Commander: create store #1609
Merged
Commander: create store #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
axios-commander
branch
from
4096791
to
c592dac
Compare
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
joaoantoniocardoso
approved these changes
Apr 21, 2023
| return back_axios({ | ||
| method: 'post', | ||
| url: `${this.API_URL}/shutdown`, | ||
| timeout: 5000, |
There was a problem hiding this comment.
Note: was 2000
| return back_axios({ | ||
| method: 'get', | ||
| url: `${this.API_URL}/raspi_config/camera_legacy`, | ||
| timeout: 5000, |
There was a problem hiding this comment.
Note: was 3000
| return back_axios({ | ||
| method: 'post', | ||
| url: `${this.API_URL}/raspi_config/camera_legacy`, | ||
| timeout: 5000, |
There was a problem hiding this comment.
Note: was 3000
There was a problem hiding this comment.
The time was updated to make it more robust
Williangalvani
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
This doesnt quite feel like a store, it is more a lib?
At the center of every Vuex application is the store. A "store" is basically a container that holds your application state. There are two things that make a Vuex store different from a plain global object:
We don't quite have a state in there.
But this is huge improvement anyway, so feel free to merge as is =]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.