-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-navigator linux boards (initially Argonot) #1625
Support non-navigator linux boards (initially Argonot) #1625
Conversation
d3fde26
to
8abbad7
Compare
8abbad7
to
59bbd87
Compare
I believe that would be more future proof to do what we currently do by default, and if there is a binary under userdata, run the binary if its valid. |
But in this case, we wouldn't offer the firmware download/update nor the board identification features to those. |
That'll be more related to: #1624, on the idea of the manifest file |
Didn't quite get it. Why not use the ardupilot one if it exists? |
|
I agree we should support this alternative. I just don't get why not to do both. |
|
Board from SymbyTech.
59bbd87
to
a1a8c54
Compare
@DevinNorgarb was it tested ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem good, adding ad-hoc code to support boards is a good solution until we have the need for something like Kraken but for 3rd party boards
94926c1
to
c60bb60
Compare
…fault firmware is available for linux board
c60bb60
to
bbd9c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by user
With this small change, we can support running Ardupilot Linux-based firmwares for boards other than the Navigator.
This was motivated to support the Argonot system, from SymbyTech (a request from @DevinNorgarb).
The only downside for now is that when there's no firmware installed for that board, we will use the one we have stored for Navigator.
The PR is in draft mode until we confirm the sensors used to identify this board.
Fix #1623.