Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button for eeprom update #1649

Merged
merged 6 commits into from
May 25, 2023
Merged

Add button for eeprom update #1649

merged 6 commits into from
May 25, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Apr 25, 2023 •
edited

image

image

@patrickelectric
core: frontend: system-information: Firmware: Add computed functions …
58eb9fe 
…for new version

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: services: commander: Add endpoint to update eeprom
e0ab3f1 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: store: commander: Update operation name since it does…
4716453 
… not update eeprom

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: components: system-information: Firmware: Use new com…
c9a5022 
…mander function name for eeprom version

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: store: commander: Add function to do eeprom update
8c9990b 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: components: system-information: Firmware: Add update …
e1aff1f 
…button for eeprom

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric patrickelectric marked this pull request as ready for review April 25, 2023 16:34
joaoantoniocardoso
joaoantoniocardoso approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good, but couldn't test the update.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label May 1, 2023
@patrickelectric
Copy link
Member Author

Documented in: bluerobotics/ardusub-zola#93

@patrickelectric patrickelectric removed the docs-needed Change needs to be documented label May 25, 2023
@patrickelectric patrickelectric merged commit 120af6b into bluerobotics:master May 25, 2023
6 of 7 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 3, 2023
@ES-Alexander ES-Alexander mentioned this pull request Aug 3, 2023
Merged
10 tasks
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickelectric @joaoantoniocardoso @ES-Alexander