Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Use round edges and color gradient based on Elisa feedback #1669

Merged
merged 1 commit into from
May 5, 2023
Merged

frontend: Use round edges and color gradient based on Elisa feedback #1669

merged 1 commit into from
May 5, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented May 5, 2023 •
edited

image

image

image

image

image

image

@joaoantoniocardoso
Copy link
Collaborator

Cool, but wouldn't this make the feel inconsistent across other pages?

@patrickelectric patrickelectric marked this pull request as ready for review May 5, 2023 15:02
@patrickelectric
frontend: Use round edges and color gradient based on Elisa feedback
f810b61 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
ES-Alexander
ES-Alexander approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background looks great :-)

Per our discussion, the service cards are acceptable, and not worth putting heaps of time in since we're planning to remove them soonish anyway once we've got a real dashboard.

Nice work! :-)

@patrickelectric patrickelectric merged commit 062a4de into bluerobotics:master May 5, 2023
4 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label May 19, 2023
@ES-Alexander ES-Alexander mentioned this pull request Jun 19, 2023
Merged
16 tasks
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ES-Alexander ES-Alexander ES-Alexander approved these changes

@rjehangir rjehangir Awaiting requested review from rjehangir

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickelectric @joaoantoniocardoso @ES-Alexander