Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: views: VehicleSetupView: Improve code and visual #1689

Merged
merged 1 commit into from
May 19, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented May 19, 2023

now:
image

before:
image

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@ES-Alexander
Copy link
Collaborator

All the other pages have the blue background coming through instead of having a flat base colour - does it perhaps make more sense to make the container for the peripherals at the bottom transparent, and then just change the styling of the tabs bar at the top to better fit with the rest of the UI elements?

Also, the Extensions Manager page also has tabs, so will need to be updated to have consistent styling with whatever we do for the Vehicle Setup view :-)

@patrickelectric
Copy link
Member Author

We can do that in future PRs

@patrickelectric patrickelectric merged commit 5f882b9 into bluerobotics:master May 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants