Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: componentes: PingInfo: Do not show if there is no device #1691

Closed

Conversation

patrickelectric
Copy link
Member

now:
image

before:
image

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@ES-Alexander
Copy link
Collaborator

This is inconsistently applied logic, so we should discuss what we want here. Are Pings special compared to things like lights or the gripper (I personally think Ping stuff belongs in an extension, so I could see an argument for "yes" on that grounds at least), or should we generally hide things if there aren't any of them available?

I think my favoured approach would be:

  1. if the software has the capability to detect something, it should have a box, with a clear indication if the thing is not detected/configured (à la "Not configured" for the current gripper display)
    • I consider "capability" to include
      • a configuration option (or combination) that tends to imply the usage of a particular device (like ArduSub params for lights1/2 and the gripper)
      • a built in service that can actually detect a device (like for the camera manager, and currently for Ping devices)
      • an installed device-integration extension (like for a DVL/USBL, and perhaps in future for Ping devices)
    • This then pulls double duty as showing both
      1. what is currently connected, as well as
      2. what the vehicle thinks it's capable of handling
  2. if there is no capability to detect it / assume it's connected, don't show a box for it

@patrickelectric
Copy link
Member Author

Pings special compared to things like lights or the gripper

Yes, ping has its own service to be detected.

My point is that, things that are automatically detected and integrated in BlueOS could be dynamically show or not, like Ping here. Meanwhile, things that need user intervention on the vehicle/or are default, should show as "Not configured".

@joaoantoniocardoso
Copy link
Member

Orrrr.... instead of hiding it, we could use that space to subtle advertise it, like Not installed, click >here< to see how to get one, linking to our store 😄

@Williangalvani
Copy link
Member

I agree it is better to say something along the lines of "No devices detected" rather than omitting the panel completely. Omitting it completely could lead users to think that "ping support is not installed", which is very relevant as there are thoughts of turning it into an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants