Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct name of image for an installed extension #1728

Merged
merged 1 commit into from
May 26, 2023

Conversation

rotu
Copy link
Contributor

@rotu rotu commented May 26, 2023

Previously, we used the second slash-separated path component instead of the last one for the image name.

This is incorrect as, e.g. in the below example. The name of the image identified by "docker.io/library/alpine" is "alpine", not "library"

image

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickelectric patrickelectric merged commit ac662da into bluerobotics:master May 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants