Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: wizard: add skip and disable options to wizard #1746

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Williangalvani
Copy link
Member

Screenshot 2023-06-06 at 00 00 50

Skip is for the current session. Disable is until the next Wizard version change.

Not quire sure how I feel about this one 馃

Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least explain the implications and how to revert the action, when possible.

maybe change "Skip" to "Do later", and require a confirmation for "disable", with a tooltip like "I want to do the system configuration manually by myself", with a dialogue explaining something like "Disabling is not recommended, and will require manual configuration. Be sure to visit the firmware and vehicle pages. To enable the wizard again, a full settings reset is necessary."

@ES-Alexander
Copy link
Collaborator

ES-Alexander commented Jun 7, 2023

Agreed with @joaoantoniocardoso that it's not very clear what these do at the moment, and that explanatory tooltips are a good idea (possibly with a (?) icon to make it clear tooltips are available). Maybe we could change the names to "Ask Me Later" and "Leave Me Alone"/"I Know What I'm Doing" or something? Also, "Disable Wizard" just sounds brutal - poor wizard... 馃槀

I also think we should have text labels for the vehicles (instead of just images), both for accessibility reasons and to make it obvious that the buttons aren't linked to the vehicle options.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jun 7, 2023
@rafaellehmkuhl
Copy link
Member

I would go for "Ask me later" and "Don't show again". Those are widely used, so users are already used to them.

@Williangalvani
Copy link
Member Author

I would go for "Ask me later" and "Don't show again". Those are widely used, so users are already used to them.

I like it.

@Williangalvani Williangalvani merged commit fb949ee into bluerobotics:master Jun 7, 2023
5 checks passed
@Williangalvani Williangalvani deleted the wizardskip branch June 7, 2023 20:07
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants