Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: frontend: wizard: add 'other' vehicle #1747

Merged
merged 1 commit into from
Jun 8, 2023
Merged

core: frontend: wizard: add 'other' vehicle #1747

merged 1 commit into from
Jun 8, 2023

Conversation

Williangalvani
Copy link
Member

image

Fix #1681

joaoantoniocardoso
joaoantoniocardoso approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we don't need to set up anything else for others

@Williangalvani Williangalvani removed the request for review from jaxxzer June 6, 2023 19:56
ES-Alexander
ES-Alexander approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, although I think it'd be useful for accessibility to have visible text labels instead of just tooltips (but not sure how much clutter that adds on small screens).

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jun 7, 2023
@Williangalvani
Copy link
Member Author

we can allow further configurations for "other" vehicles, but I think this is a decent start

@Williangalvani Williangalvani merged commit e33685d into bluerobotics:master Jun 8, 2023
5 of 6 checks passed
@Williangalvani Williangalvani deleted the other branch June 8, 2023 15:51
@ES-Alexander ES-Alexander mentioned this pull request Jun 19, 2023
Merged
16 tasks
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@ES-Alexander ES-Alexander ES-Alexander approved these changes

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: frontend: Add "Other" vehicle type to Wizard setup for users that are not setting up a BROV2 or BlueBoat
3 participants
@Williangalvani @joaoantoniocardoso @ES-Alexander