core: frontend: use flex containers for extensions store #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
requested review from
joaoantoniocardoso,
rafaellehmkuhl and
ES-Alexander
|
Can you show a screenshot of what this looks like? The code change looks mostly ok, but IIRC SMS has been keen on things being consistently sized (like the service displays on the dashboard), and I'm not sure if this PR changes that to allow some extension cards to show up larger or smaller than others. |
joaoantoniocardoso
approved these changes
Jun 7, 2023
it looks exactly the same for "full window", only changing when you resize it down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1753