Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: frontend: parameterEditorDialog: save when pressing enter #1774

Merged
merged 1 commit into from
Jun 12, 2023
Merged

core: frontend: parameterEditorDialog: save when pressing enter #1774

merged 1 commit into from
Jun 12, 2023

Conversation

Williangalvani
Copy link
Member

fix #1665

ES-Alexander
ES-Alexander approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the syntax here, but I'm assuming you've tested it, and it's definitely a welcome feature :-)

@Williangalvani Williangalvani merged commit d1743a3 into bluerobotics:master Jun 12, 2023
6 checks passed
@Williangalvani Williangalvani deleted the fix_pressing_enter branch June 12, 2023 05:08
@Williangalvani
Copy link
Member Author

I'm not familiar with the syntax here, but I'm assuming you've tested it, and it's definitely a welcome feature :-)

the .prevent part prevents the default behavior of submitting the form, which refreshed the browser. the new function runs in its place, writing the parameter =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ES-Alexander ES-Alexander ES-Alexander approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Williangalvani @ES-Alexander