Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs on ParameterEditorDialog #1776

Merged

Conversation

Williangalvani
Copy link
Member

fix #1771 and a another bug where we had to click outside of the textfield for the save button to get enabled.

Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Maybe add a comment that the <0 check means it's disabled or something (if that's what it means), but up to you.

@Williangalvani Williangalvani merged commit 10c3f15 into bluerobotics:master Jun 12, 2023
2 checks passed
@Williangalvani Williangalvani deleted the negatives_are_numbers_too branch June 12, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parameter editor doesnt allow setting SERVOX_FUNCTION params to -1
2 participants