-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: frontend: wizard: move wifi connection to first step of wizard #1782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, someone needs to test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI is kinda broken: the fourth step is not on the top.
ui_broken.mp4
Also, I think it should be something like:
# BlueOS Wizard
---
< Some introductory message like..: > Hello, this wizard will help you
set up your vehicle for its first use! In order to fetch firmware and
other data from the internet, please ensure that you have a wired
internet connection, or click the button below to configure your WiFi connection.
[x] Trying to reach the internet via cable... Failed.
[ask me later] [don't show again] [configure WiFi] [retry]
and then, the WiFi dialogue shows if you click there.
edit: We might then, remove the old 'welcome to BlueOS' message, would be redundant
@joaoantoniocardoso wired internet is going to be very rare. I don't think it should be mentioned. The wifi step should already be skipped automatically if internet is detected in any form. I do like the idea of a welcome text, and I'll trim the steps so we only have 4 |
I see... But do we want it to be rare? If we are designing Cockpit to handle multiple clients, I think the most common setup (for multiple clients) would be the vehicle connected to a router, and then I can imagine (at least half) of the users would prefer to just have the internet cable to that router too, sharing between all computers and vehicle. |
I am confused, so all vehicles would be effectively wired together? 🤔 |
Possibly -- multiple pilots, multiple vehicles, meaning multiple MDNS addresses, multiple Cockpit setups, etc. |
fix #1781