Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: wizard: move wifi connection to first step of wizard #1782

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Williangalvani
Copy link
Member

fix #1781

Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, someone needs to test it

Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI is kinda broken: the fourth step is not on the top.

ui_broken.mp4

Also, I think it should be something like:

# BlueOS Wizard
---
< Some introductory message like..: > Hello, this wizard will help you
 set up your vehicle for its first use! In order to fetch firmware and
 other data from the internet, please ensure that you have a wired
 internet connection, or click the button below to configure your WiFi connection.

[x] Trying to reach the internet via cable... Failed. 

[ask me later] [don't show again] [configure WiFi] [retry]

and then, the WiFi dialogue shows if you click there.

edit: We might then, remove the old 'welcome to BlueOS' message, would be redundant

@Williangalvani
Copy link
Member Author

@joaoantoniocardoso wired internet is going to be very rare. I don't think it should be mentioned. The wifi step should already be skipped automatically if internet is detected in any form.

I do like the idea of a welcome text, and I'll trim the steps so we only have 4

@joaoantoniocardoso
Copy link
Collaborator

joaoantoniocardoso commented Jun 13, 2023

@joaoantoniocardoso wired internet is going to be very rare. I don't think it should be mentioned. The wifi step should already be skipped automatically if internet is detected in any form.

I do like the idea of a welcome text, and I'll trim the steps so we only have 4

I see... But do we want it to be rare? If we are designing Cockpit to handle multiple clients, I think the most common setup (for multiple clients) would be the vehicle connected to a router, and then I can imagine (at least half) of the users would prefer to just have the internet cable to that router too, sharing between all computers and vehicle.

@Williangalvani
Copy link
Member Author

I see... But do we want it to be rare? If we are designing Cockpit to handle multiple clients, I think the most common setup (for multiple clients) would be the vehicle connected to a router, and then I can imagine (at least half) of the users would prefer to just have the internet cable to that router too, sharing between all computers and vehicle.

I am confused, so all vehicles would be effectively wired together? 🤔

@joaoantoniocardoso
Copy link
Collaborator

I am confused, so all vehicles would be effectively wired together? thinking

Possibly -- multiple pilots, multiple vehicles, meaning multiple MDNS addresses, multiple Cockpit setups, etc.

@Williangalvani Williangalvani merged commit b65dfe6 into bluerobotics:master Jun 13, 2023
5 checks passed
@Williangalvani Williangalvani deleted the fixwifi branch June 13, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wifi internet picking should be the first step
2 participants