Major Tom 2: A missão #2031
Merged
Major Tom 2: A missão #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Williangalvani
force-pushed
the
major_tomv2
branch
5 times, most recently
from
7d2ef8d
to
eb7d5f1
Compare
Williangalvani
force-pushed
the
major_tomv2
branch
8 times, most recently
from
86e574a
to
8a4566b
Compare
Williangalvani
requested review from
voorloopnul,
patrickelectric and
joaoantoniocardoso
patrickelectric
requested changes
Sep 14, 2023
| def installed_version(self) -> Optional[VersionInfo]: | ||
| try: | ||
| req = requests.get("http://localhost/version-chooser/v1.0/version/current", timeout=3) | ||
| if req.status_code == 200: |
There was a problem hiding this comment.
Suggested change
| if req.status_code == 200: | |
| if req.status_code == http.client.OK: |
Williangalvani
force-pushed
the
major_tomv2
branch
6 times, most recently
from
c94406e
to
20b05af
Compare
patrickelectric
requested changes
Sep 15, 2023
Williangalvani
force-pushed
the
major_tomv2
branch
2 times, most recently
from
18672fc
to
89edc8a
Compare
patrickelectric
requested changes
Sep 19, 2023
| def installed_version(self) -> Optional[VersionInfo]: | ||
| try: | ||
| req = requests.get("http://localhost/version-chooser/v1.0/version/current", timeout=3) | ||
| if req.status_code == 200: |
core/services/major_tom/src/core.py
Outdated
| timestamp: str | ||
| hardware_id: str | ||
| blueos_id: str | ||
| data: dict[str, Any] |
There was a problem hiding this comment.
Since this is a generic dict, aren't we supposed to have the serialized data with a defined type property to specify what is exactly in this field ?
Like:
data: {
type: 'AnonymousTelemetryRecord'
...
}
Williangalvani
force-pushed
the
major_tomv2
branch
from
89edc8a
to
f55ad16
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates Major Tom, again. The code is mostly by @voorloopnul
This leverages on loguru to store and rotate the data.