core: frontend: do not update motors when blueos is not in focus #2243
Conversation
|
I didn't test it, but just a reminder: we should show feedback that it was canceled because the user changed the window. |
Williangalvani
force-pushed
the
no_motors_out_of_focus
branch
from
af59dad
to
ccd7007
Compare
| @@ -350,11 +372,17 @@ export default Vue.extend({ | |||
| }, | |||
| printParam, | |||
| zero_motors() { | |||
| if (!this.has_focus) { | |||
| return | |||
There was a problem hiding this comment.
This is a case where we should be safe to run if out of focus no ?
There was a problem hiding this comment.
I'd prefer to stop completely in case the user is trying to do something else.
We need to check if rover has a decent motor test timeout, actually.
There was a problem hiding this comment.
But this is zero_motors.. isn't this supposed to be the safest way than letting a undefined state ?
There was a problem hiding this comment.
we don't want to interfere if the user is using another software. we should probably send one zero_motors and then stop completely
There was a problem hiding this comment.
Can we have a comment explaining that ? This is not clear from the code.
There was a problem hiding this comment.
Can we have a comment explaining that ? This is not clear from the code.
the code wasn't doing it before. I added a boolean to keep track of it.
Williangalvani
force-pushed
the
no_motors_out_of_focus
branch
from
ccd7007
to
3656647
Compare
should fix #2206
needs testing