Bridges update #2322
Bridges update #2322
Conversation
Williangalvani
force-pushed
the
bridges_update
branch
2 times, most recently
from
cf77796
to
1bd4cb3
Compare
core/start-blueos-core
Outdated
| @@ -15,6 +15,7 @@ MAV_COMPONENT_ID_ONBOARD_COMPUTER4=194 | |||
| # Enable Rust backtrace for all programs | |||
| RUST_BACKTRACE=1 | |||
|
|
|||
| RUN_AS_BLUEOS_USER="sudo -u blueos" | |||
There was a problem hiding this comment.
in case sudo is not available, you can su blueos -c "commandline with arguments"
There was a problem hiding this comment.
the quotes in there make commands insanely hard to assemble. Do you want to take a look at it? I tried for a while but ended up giving up
There was a problem hiding this comment.
it should be something like:
BLUEOS_USER='blueos'
run_as_blueos_user () {
su "$BLUEOS_USER" -c "$1"
}
run_as_blueos_user 'ls -lah /dev/video*'There was a problem hiding this comment.
didn't quite work, I think this need to be on its own file so it can be used inside the new tmux sessions.
I'll try it in a subsequent pr
Williangalvani
force-pushed
the
bridges_update
branch
3 times, most recently
from
29e952c
to
9a69775
Compare
Williangalvani
force-pushed
the
bridges_update
branch
8 times, most recently
from
2722437
to
d293e8d
Compare
Williangalvani
requested review from
patrickelectric,
joaoantoniocardoso and
JoaoMario109
Williangalvani
force-pushed
the
bridges_update
branch
from
d293e8d
to
5f01dfa
Compare
core/services/bridget/settings.py
Outdated
| "udp_listen_port": spec["udp_port"] if server else 0, | ||
| } | ||
| ) | ||
| data["specsv2"] = new_specs |
There was a problem hiding this comment.
why not just replacing specs directly ?
There was a problem hiding this comment.
sounds good, that is just how my brain works. updated.
core/start-blueos-core
Outdated
| @@ -85,6 +86,12 @@ else | |||
| echo "Waring: Using dockers's resolv.conf, this may cause DNS issues if the host's network configuration changes." | |||
| fi | |||
|
|
|||
| # fix permissions for logging folders: | |||
| find /var/logs/blueos -type d -exec chmod 777 {} \; | |||
There was a problem hiding this comment.
The default folder permission should be "755", no ?
| self._bridges: Dict[BridgeSpec, Bridge] = {} | ||
| self._settings_manager = Manager("bridget", SettingsV1) | ||
| self._bridges: Dict[BridgeFrontendSpec, Bridge] = {} | ||
| self._settings_manager = Manager("bridget", SettingsV2, USERDATA / "settings" / "bridget") |
There was a problem hiding this comment.
Why are we moving this to userdata over our standard settings folder ?
There was a problem hiding this comment.
non-root users have no access to our regular folder because it is under /root/
There was a problem hiding this comment.
It would be nice to have a comment explaining that in the code
…t services The user they run under has no permission for setting the memory use budget
Williangalvani
force-pushed
the
bridges_update
branch
from
5f01dfa
to
b0af3a3
Compare
|
cool, I'm trying @joaoantoniocardoso 's suggestion and I'll merge it after I'm done |
Williangalvani
force-pushed
the
bridges_update
branch
2 times, most recently
from
41f36e8
to
dc4cb6b
Compare
Williangalvani
force-pushed
the
bridges_update
branch
from
dc4cb6b
to
b9ccd93
Compare
The previous code did not work since it was running with the extensions folder that can have a huge number of files Not sure about the original work done in: bluerobotics#2322 Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
The previous code did not work since it was running with the extensions folder that can have a huge number of files Not sure about the original work done in: #2322 Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
This splits udp port handling into udp target port and udp lister port.
client will always send data to
udp_target_port.server will always listen at
udp_listen_port.additionally, this now allows the client to pick the port it will bind to, using
udp_listen_port.this is useful for implementations where whatever is talking to us is sending/receiving packets naively, without an actual udp "connection".
depends on patrickelectric/bridges#11fix #2305
fix #2304