core: frontend: onboardSensors: fix internal baro showing as water pressure sensor

[Williangalvani]

needs testing (I can't find my spare bar30)

[ES-Alexander]

Nice!

Per my comment in #2567, this fixes a bug but is only a partial fix for the observed behaviour, because we’re saying MS5611 is a water sensor (to handle the current misrepresentation of the MS5837 on the Bar30), and the Pixhawk has a genuine MS5611 as its onboard barometer (so that one will still show up as water unless we handle it explicitly). Alternatively we could stop treating MS5611 as water except in the special case where we expect it’s actually an MS5837, e.g. when it’s used on a sub vehicle and connected via I2C instead of SPI.

[Williangalvani]

Nice!

Per my comment in #2567, this fixes a bug but is only a partial fix for the observed behaviour, because we’re saying MS5611 is a water sensor (to handle the current misrepresentation of the MS5837 on the Bar30), and the Pixhawk has a genuine MS5611 as its onboard barometer (so that one will still show up as water unless we handle it explicitly). Alternatively we could stop treating MS5611 as water except in the special case where we expect it’s actually an MS5837, e.g. when it’s used on a sub vehicle and connected via I2C instead of SPI.

hmmm makes sense! we can check if it is on i2c and connected to bus BARO_EXT_BUS