Improve ethernet ping device handling #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (internal) registered driver in a device descriptor should not be a differentiating factor for whether another descriptor pertains to the same physical (external) device.
ES-Alexander
force-pushed
the
fix-ethernet-ping-registration
branch
2 times, most recently
from
7d95d95
to
94437f2
Compare
ES-Alexander
force-pushed
the
fix-ethernet-ping-registration
branch
from
94437f2
to
03ae4a1
Compare
|
Matthew has tested, and it does appear to fix the duplication :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some robustness improvements that will hopefully fix #2569.
I've tested this on my machine, and it doesn't seem to have any regressions, and the dropped network device handling works 馃憤
Not sure whether it fixes the duplication issue because I haven't run into it in the first place, so I've asked Aaron to see if the issue is fixed on his system.
Given the PR doesn't seem to hurt things we could potentially merge as-is, but it may also be worth waiting to see whether the issue is actually resolved (by testing from someone who can replicate it).