Kraken: Improv main loop checks and modify raw body install to be atomic #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoMario109
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
* Moved from using + to generate unique identifier in kraken main loop lock to use a f string and generate finmal identifier in safer way * Lock the kraken main loop from trying to restore some extension that is being removed instead of only locking the pull process
* Add option to raw body installs be atomic, since they are likely to use private repos and require auth to install there is no point on keep kraken trying to fix the installation after.
JoaoMario109
force-pushed
the
add-atomic-option-kraken-install
branch
from
763a59b
to
61548e5
Compare
patrickelectric
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.