-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pre-push hooks, and move to Poetry #2677
fix pre-push hooks, and move to Poetry #2677
Conversation
38620f4
to
faf8ae1
Compare
d061898
to
9bf0381
Compare
a37bb72
to
367375e
Compare
367375e
to
39ad34b
Compare
39ad34b
to
ace39c5
Compare
works great once it works! but I had to manually configure a local python3.11 with pyenv. can we add a check for python version and add hints on how to set it up?
|
@Williangalvani is the command |
e6fe7ca
to
bb2c376
Compare
once you do altenatively,
|
bb2c376
to
bed0a9a
Compare
Okay, I rewrote the Python check code to automatically use pyenv if it's available |
working well locally here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! this is so much better!
bed0a9a
to
64332a2
Compare
@Williangalvani I just rebased, some of the commits were already merged. |
This migrates the hooks/pre-push to use Poetry directly, and makes all the files contained within the project's virtual environment, instead of loading files on the users' folder, making the development environment more replicable.
To use the pre-push, the user must have a Python 3.11 available. Before, it would use whatever the system's Python was, failing to run when the user had 3.12 or 3.10 for example.
To test:
\rm -rf .venv poetry.lock
.hooks/pre-push
To check whether it had any impact on the normal installation:
joaoantoniocardoso/blueos-core
:fix-pre-push
on BlueOSI have tested it myself, but more samples are welcome.
After this patch is merged, we can all clean our system:
ls "$(python -m site --user-site)"
ls "$(python -m site --user-base)/bin"