-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links #60
Fix broken links #60
Conversation
The first commit here addresses the first failure shown here: https://travis-ci.org/bluerobotics/bluerobotics.github.io/builds/386272848#L676 |
@mariya-bluerobotics I would have preferred the link fixes go in separate commits. As a general rule, I like for a commit to contain changes inside only a single directory. This is not something to hold this PR up, though. Please rebase and resolve the conflicts 🙃 It is a little bit weird that there is a merge commit here. If you are not sure of what you are doing with git, please ask. |
Hey Jacob, You want me to do every error in a different commit? I am not sure if I understand. Do you want me to do errors in one file in a single commit or like each individual error in different commits? |
4b8cee6
to
78acb59
Compare
…does not exist: fixed
…s not exist: fixed
@mariyachanniwala it looks like our rebase uncovered some more CI failures. Please have a look, let me know if they look like things you have already addressed. |
Yeah these are all new issues. Looks like I need to change a few more things. I dont know how that happened though. |
magic |
Thanks! |
no problem! |
Fix #58