Skip to content

Commit

Permalink
webrtc: session: Allow Session object to add updates to the stream …
Browse files Browse the repository at this point in the history
…status
  • Loading branch information
rafaellehmkuhl committed Apr 18, 2024
1 parent 891fe13 commit 767ef2a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/composables/webRTC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ export class WebRTCManager {
this.selectedICEIPs,
(event: RTCTrackEvent): void => this.onTrackAdded(event),
(availableICEIPs: string[]) => (this.availableICEIPs.value = availableICEIPs),
(_sessionId, reason) => this.onSessionClosed(reason)
(_sessionId, reason) => this.onSessionClosed(reason),
(status: string): void => this.updateStreamStatus(status)
)

// Registers Session callback for the Signaller endSession parser
Expand Down
8 changes: 7 additions & 1 deletion src/libs/webrtc/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { Stream } from '@/libs/webrtc/signalling_protocol'
type OnCloseCallback = (sessionId: string, reason: string) => void
type OnTrackAddedCallback = (event: RTCTrackEvent) => void
type onNewIceRemoteAddressCallback = (availableICEIPs: string[]) => void
type OnStatusChangeCallback = (status: string) => void

/**
* An abstraction for the Mavlink Camera Manager WebRTC Session
Expand All @@ -23,6 +24,7 @@ export class Session {
public onTrackAdded?: OnTrackAddedCallback
public onNewIceRemoteAddress?: onNewIceRemoteAddressCallback
public onClose?: OnCloseCallback
public onStatusChange?: OnStatusChangeCallback

/**
* Creates a new Session instance, connecting with a given Stream
Expand All @@ -34,7 +36,9 @@ export class Session {
* @param {string[]} selectedICEIPs - A whitelist for ICE IP addresses, ignored if empty
* @param {OnTrackAddedCallback} onTrackAdded - An optional callback for when a track is added to this session
* @param {onNewIceRemoteAddressCallback} onNewIceRemoteAddress - An optional callback for when a new ICE candidate IP addres is available
* @param {onNewIceRemoteAddressCallback} onNewIceRemoteAddress - An optional callback for when a new ICE candidate IP addres is available
* @param {OnCloseCallback} onClose - An optional callback for when this session closes
* @param {OnStatusChangeCallback} onStatusChange - An optional callback for internal status change
*/
constructor(
sessionId: string,
Expand All @@ -45,14 +49,16 @@ export class Session {
selectedICEIPs: string[] = [],
onTrackAdded?: OnTrackAddedCallback,
onNewIceRemoteAddress?: onNewIceRemoteAddressCallback,
onClose?: OnCloseCallback
onClose?: OnCloseCallback,
onStatusChange?: OnStatusChangeCallback
) {
this.id = sessionId
this.consumerId = consumerId
this.stream = stream
this.onTrackAdded = onTrackAdded
this.onNewIceRemoteAddress = onNewIceRemoteAddress
this.onClose = onClose
this.onStatusChange = onStatusChange
this.status = ''
this.signaller = signaller
this.rtcConfiguration = rtcConfiguration
Expand Down

0 comments on commit 767ef2a

Please sign in to comment.