Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of longer videos (49min) takes a lot of time to start #929

Closed
rafaellehmkuhl opened this issue Apr 30, 2024 · 4 comments · Fixed by #998
Closed

Download of longer videos (49min) takes a lot of time to start #929

rafaellehmkuhl opened this issue Apr 30, 2024 · 4 comments · Fixed by #998
Assignees
Labels
bug Something isn't working investigate P0 - Critical Priority Highest priority over all priorities video

Comments

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Apr 30, 2024

The video processed fine and is viewable in the built-in player, but when it was time to download it, it didn't work.

image

The snackbar appeared and that was it. Downloading smaller videos (1min) worked fine.
After trying to download this larger one, trying again to download the smaller one also failed.

@rafaellehmkuhl rafaellehmkuhl added bug Something isn't working P0 - Critical Priority Highest priority over all priorities video labels Apr 30, 2024
@rafaellehmkuhl rafaellehmkuhl added this to the From Beta to Stable milestone Apr 30, 2024
@rafaellehmkuhl rafaellehmkuhl changed the title Could not download long (49min) video Download of longer videos (49min) takes a lot of time to start Apr 30, 2024
@rafaellehmkuhl
Copy link
Member Author

Update: after about 2 minutes, Chrome started to download it (as it is a local file, it downloaded instantly).

As a user, I would just assume it failed. We should consider that as a critical bug.

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented May 17, 2024

Just tested and a 10 minutes video is taking 15 seconds to start downloading. 40 seconds for a 22min video.

@rafaellehmkuhl
Copy link
Member Author

From my tests, what is taking a lot of time is the process of zipping the files. It's strange, since this didn't use to take long on the old implementation, but the code does not seen to have changed significantly on this part.

@rafaellehmkuhl rafaellehmkuhl self-assigned this Jun 11, 2024
@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jun 13, 2024

Got the problem: in the old implementation we had the option to download only the video file separately, without zipping, and this was fast. When zipping, even in the old implementation, it was taking the same time.

PS: git is a magical tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigate P0 - Critical Priority Highest priority over all priorities video
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant