widgets[video-recorder]: Handle edge cases for screen recording #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
fix-recording-for-solo-stream
branch
2 times, most recently
from
f78a188
to
037743b
Compare
rafaellehmkuhl
force-pushed
the
fix-recording-for-solo-stream
branch
3 times, most recently
from
23798ab
to
5c9bc38
Compare
rafaellehmkuhl
force-pushed
the
fix-recording-for-solo-stream
branch
from
5c9bc38
to
ffd4fa7
Compare
rafaellehmkuhl
requested review from
patrickelectric
and removed request for
patrickelectric
|
@patrickelectric just to make sure, this PR should be approved/merged first. |
patrickelectric
requested changes
Mar 29, 2023
- Handle no streams being available - Handle user not selecting stream - Handle user denying screen sharing - Handle media stream not active
In the former behavior, the user permission was requested when selecting the screen stream option. This yeld to the browser adding a 'recording' warn, even if the recording had not yet started. This could lead to the users thinking that the recording had already started, forgething to click the record button. In the new behavior, the permission is asked *after* clicking the record button, making clear what's happening.
rafaellehmkuhl
force-pushed
the
fix-recording-for-solo-stream
branch
from
ffd4fa7
to
a9e7810
Compare
|
@patrickelectric I need approval on this one also. |
patrickelectric
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #269