Parse vehicle parameter table once #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous implementation, the reactive property of the store was updated hundred of times on the initial parsing, leading to a performance bottleneck. The new implementation parse the entire metadata and then assign it to the reactive property, so it prevents unnecessary reactive calculations.
patrickelectric
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous implementation, the reactive property of the store was updated hundreds of times on the initial parsing, leading to a performance bottleneck.
The new implementation parse the entire metadata and then assign it to the reactive property, so it prevents unnecessary reactive calculations.
Fix #362.
Parsing went from 1.2 seconds to 12 milliseconds.