Automatically set ice ips #663
Conversation
rafaellehmkuhl
force-pushed
the
automatically-set-ice-ips
branch
from
b8f28d6
to
f8bc845
Compare
| const isIceIp = availableIceIps.value.includes(ipInfo.ipv4Address) | ||
| const alreadyAllowedIp = allowedIceIps.value.includes(ipInfo.ipv4Address) | ||
| if (ipInfo.interfaceType !== 'WIRED' || alreadyAllowedIp || !isIceIp) return | ||
| console.info(`Adding the wired address '${ipInfo.ipv4Address}' to the list of allowed ICE IPs.`) | ||
| allowedIceIps.value.push(ipInfo.ipv4Address) |
There was a problem hiding this comment.
I'm late for the party, but just for future note, this IPv4 thing is a nightmare. I know BlueOS doesn't use IPv6, but nothing is helping to debug when the ICE strategy fails because it's using IPv6.
There was a problem hiding this comment.
Hey Joao, could you detail the situation where this is creating a problem? Are IPv6 addresses being offered on the allowed list right now or are you talking about manual inputed ones?
There was a problem hiding this comment.
There are no restrictions on the MCM side, so when the network uses IPV6, ICE will use it, and Cockpit will not be able to use it, right?
There was a problem hiding this comment.
Got it!
I'm actually not sure.
Is beacon providing information on IPv6 addresses?
Can you check at http://blueos.local/beacon/v1.0/services? I don't have IPv6 here to check.
@Williangalvani does Beacon works with IPv6?
Fix #659.
To be merged after #655.