Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video-player: Add rotation #681

Merged
merged 1 commit into from
Jan 9, 2024
Merged

video-player: Add rotation #681

merged 1 commit into from
Jan 9, 2024

Conversation

joaoantoniocardoso
Copy link
Member

I'm just annoyed with my flipped video when testing here.

Helps #20

rafaellehmkuhl
rafaellehmkuhl approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working!
I was also in need for that one from time to time! Nice!

@rafaellehmkuhl rafaellehmkuhl merged commit 3311726 into bluerobotics:master Jan 9, 2024
8 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the add_rotation branch January 9, 2024 16:05
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 26, 2024
@ES-Alexander
Copy link
Contributor

Now we just need to allow incremental rotation tied to the vehicle roll angle, and we can have stabilised footage! :-P

@rafaellehmkuhl
Copy link
Member

Now we just need to allow incremental rotation tied to the vehicle roll angle, and we can have stabilised footage! :-P

HAHAHAHAHAHAHHAHA

Now I need to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

Assignees
No one assigned
Labels
docs-needed Change needs to be documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joaoantoniocardoso @ES-Alexander @rafaellehmkuhl