system-logging: Make system logger print/log more than the first call argument #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling the system logs allow developers to see where do the console calls come from.
rafaellehmkuhl
force-pushed
the
fix-system-logs
branch
from
457f716
to
8ebdbd2
Compare
rafaellehmkuhl
force-pushed
the
fix-system-logs
branch
from
2f130ea
to
e48d4c7
Compare
patrickelectric
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is still not saving objects correctly to the system logs. For some reason, stringifying them is causing a serious performance overhead, so I just kept them not being logged for now. As this already allows them to be printed by the console and extra console arguments to be printed as well, it's already a win.
Fix #685