Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less clicks to record #706

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jan 25, 2024

Screen.Recording.2024-01-25.at.16.05.55.mov

@pkmiles there's a start here for what you were suggesting on #698.

Fix #705

@ES-Alexander
Copy link
Contributor

Nice! :-)

Would it be hard to make the name only scroll while it's being hovered over, and otherwise just show the start?
I feel like if it's constantly scrolling it could be annoying/distracting.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 26, 2024
@patrickelectric
Copy link
Member

Nice! :-)

Would it be hard to make the name only scroll while it's being hovered over, and otherwise just show the start? I feel like if it's constantly scrolling it could be annoying/distracting.

Great suggestion

@rafaellehmkuhl
Copy link
Member Author

Nice! :-)

Would it be hard to make the name only scroll while it's being hovered over, and otherwise just show the start? I feel like if it's constantly scrolling it could be annoying/distracting.

Great idea. Will change.

@rafaellehmkuhl
Copy link
Member Author

Ok. @ES-Alexander this will be a little bit trickier than I guessed. You see, because the div is actually moving while you hover, you kind of stop hovering as soon as the animation starts, causing it to stutter.

I will try to look back at this by the end of the day.

@ES-Alexander
Copy link
Contributor

… this will be a little bit trickier than I guessed. You see, because the div is actually moving while you hover, you kind of stop hovering as soon as the animation starts, causing it to stutter.

Would it be any easier to trigger a single scroll through on mouse enter? I don’t think it needs repeated continuous scrolling at any point.

@rafaellehmkuhl
Copy link
Member Author

… this will be a little bit trickier than I guessed. You see, because the div is actually moving while you hover, you kind of stop hovering as soon as the animation starts, causing it to stutter.

Would it be any easier to trigger a single scroll through on mouse enter? I don’t think it needs repeated continuous scrolling at any point.

Good point! Just did it.

Screen.Recording.2024-01-30.at.15.00.22.mov

@rafaellehmkuhl rafaellehmkuhl requested review from ES-Alexander and patrickelectric and removed request for patrickelectric January 30, 2024 18:02
@rafaellehmkuhl rafaellehmkuhl merged commit 243bdfe into bluerobotics:master Jan 30, 2024
7 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the less-clicks-to-record branch January 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MiniVideoRecorder: Allow recording without having to re-select stream
3 participants