Fix some stuff around the code #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patrickelectric
commented
Feb 22, 2024
patrickelectric
commented
- add missing await calls
- move variables to const and let where possible
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…dateCurrentStream Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
requested review from
rafaellehmkuhl,
joaoantoniocardoso and
Williangalvani
patrickelectric
force-pushed
the
add-await
branch
from
56ac582
to
f55c467
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…Address Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
add-await
branch
from
f55c467
to
30caea8
Compare
joaoantoniocardoso
approved these changes
Feb 22, 2024
Comment on lines
-183
to
+186
| const resetGlobalAddress = (): void => { | ||
| const resetGlobalAddress = async (): Promise<void> => { | ||
| newGlobalAddress.value = defaultGlobalAddress | ||
|
|
||
| setGlobalAddress() | ||
| await setGlobalAddress() |
There was a problem hiding this comment.
Why would this be async?
There was a problem hiding this comment.
It's defined as async
There was a problem hiding this comment.
Humnnnn, the form validation is async, didn't know that.
Comment on lines
+446
to
+447
| // We use a self invoked await function to avoid moving the entire store to async | ||
| ;(async () => importProfilesFromVehicle())() |
There was a problem hiding this comment.
I'm not familiar with that workaround. Will this actually wait?
There was a problem hiding this comment.
There was a problem hiding this comment.
Interesting. More on that here.
rafaellehmkuhl
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.