Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widgets selection bar (on the edit-menu) removing multiple simultaneously scroll events #771

Merged

Conversation

JoaoMario109
Copy link
Contributor

Add check for TrackPad and horizontal scroll to avoid multiple wheel and scroll events to interact simultaneously.
Fixes #753

rafaellehmkuhl

This comment was marked as outdated.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I think the solution is not working :(

The trackpad case is being detected, and so the trackpad is working fine, but using the mouse scroll is not doing anything.

* Add isHorizontalScroll function to allow to detect a wheel event
  potentially associated with a horizontal scroll.
* Add checks and better calculation to avoid multiple events to
  happening togheter in the same container
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working perfectly now, with mouse scroll, touchpad vertically and touchpad horizontally.
It couldn't be better!

@rafaellehmkuhl rafaellehmkuhl merged commit cbaaeb1 into bluerobotics:master Feb 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets selection bar (on the edit-menu) cannot be side-scrolled properly
2 participants