Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat edge-cases on the VideoPlayer and MiniVideoRecorder #774

Merged

Conversation

rafaellehmkuhl
Copy link
Member

  • Assert video is available before start recording
  • Auto-assign stream (only if there's only one stream available)
  • Let the user know if the selected stream is loading or not available
image image

Fix #773
Fix #270
Fix #763
Fix #764

@rafaellehmkuhl rafaellehmkuhl requested a review from a team February 26, 2024 19:05
@rafaellehmkuhl rafaellehmkuhl marked this pull request as draft February 26, 2024 19:59
@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Feb 26, 2024

Converting to draft to change the default behavior when there's more than one stream available on a cold boot.

Good to go.

@joaoantoniocardoso
Copy link
Contributor

Auto-assign stream (only if there's only one stream available)

I was thinking... This will create an inconvenient scenario where Cockpit changes all secondary video widgets to the same video if the older secondary streams are not available for some reason ( for example, if the guy is recreating or changing the endpoints configuration ).

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Feb 26, 2024

I was thinking... This will create an inconvenient scenario where Cockpit changes all secondary video widgets to the same video if the older secondary streams are not available for some reason ( for example, if the guy is recreating or changing the endpoints configuration ).

Actually, it will only do the auto-assign if there's no stream selected, so we are good.

@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review February 27, 2024 01:20
@patrickelectric patrickelectric merged commit c7c69ea into bluerobotics:master Feb 27, 2024
7 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the make-video-great-again-2 branch March 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants