Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SURFTRAK mode support for ArduSub #787

Merged
merged 2 commits into from Feb 29, 2024

Conversation

ES-Alexander
Copy link
Contributor

Fixes #786.

⚠️ UNTESTED - I just figured I'd get the code started, and hopefully someone can comment if there's something obvious I'm missing.

If possible it would be nice to have the mode and joystick button disabled for firmwares that don't support them (e.g. for non-ArduSub vehicles, and ArduSub <4.5), or at least provide an obvious warning when trying to switch to it (this may already happen if the vehicle rejects the mode change - not sure), but I'm not sure how to do either of those things.

@clydemcqueen may have some input as well.


@rafaellehmkuhl as a small comment, it seems weird to me to have to put the same information in twice in the mavlink-manual-control.ts file - could the button function actions not be added dynamically using the MAVLinkButtonFunction enum?

New flight mode for holding altitude using rangefinder readings (e.g. to track a set distance above the seafloor surface regardless of depth).
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible it would be nice to have the mode and joystick button disabled for firmwares that don't support them (e.g. for non-ArduSub vehicles, and ArduSub <4.5), or at least provide an obvious warning when trying to switch to it (this may already happen if the vehicle rejects the mode change - not sure), but I'm not sure how to do either of those things.

We can add rules on Cockpit, although I think this should be on the vehicle side, otherwise we will have to keep track of every firmware change ever (e.g.: answering something like "Mode 13 does not exist in vehicle" would solve the problem). @Williangalvani what do you think?

@rafaellehmkuhl as a small comment, it seems weird to me to have to put the same information in twice in the mavlink-manual-control.ts file - could the button function actions not be added dynamically using the MAVLinkButtonFunction enum?

You can actually reuse the enum there on the end of line 239. I've tried different approachs and didn't like any and kept that in the end, but is open for improvement.

@rafaellehmkuhl rafaellehmkuhl merged commit b617b0e into bluerobotics:master Feb 29, 2024
8 checks passed
@ES-Alexander ES-Alexander deleted the add-surftrak branch April 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SURFTRAK mode for ArduSub
2 participants