Add SURFTRAK
mode support for ArduSub
#787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786.
If possible it would be nice to have the mode and joystick button disabled for firmwares that don't support them (e.g. for non-ArduSub vehicles, and ArduSub <4.5), or at least provide an obvious warning when trying to switch to it (this may already happen if the vehicle rejects the mode change - not sure), but I'm not sure how to do either of those things.
@clydemcqueen may have some input as well.
@rafaellehmkuhl as a small comment, it seems weird to me to have to put the same information in twice in the
mavlink-manual-control.ts
file - could the button function actions not be added dynamically using theMAVLinkButtonFunction
enum?