We love video here #788
Merged
We love video here #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrency is not parallelism, so the comment was technically wrong.
Reduces the chances of collision without being too big.
This event should happen as fast as possible, so if we can do something outside it, we should. Also, as we are generating a guaranteed-unique hash before starting the recording, and because the chunk count is updated before anything, there's no chance of having two chunks with the same name.
The sorting happens in-place, and the previous syntax could let to think we are creating a copy of the original array, which is not the case.
JoaoMario109
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addss some small pre-commits so it gets easier to review the next one, which will change the video recovery logic.