Bug Fix: Fixing Mode Change Selector Commanding Mode Change Back to Original Mode #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjohnson97
force-pushed
the
bug_fix/mode_switch_fail
branch
from
154ede2
to
ac6ea1e
Compare
rafaellehmkuhl
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #742
This change fixes an issue where a user selects a new mode to change the vehicle to, but the mode does not change. This happens because the mode selector is commanding a mode change based on when the variable
currentModeis changed. This variable is driven off of 2 sources.When a user changes the dropdown menu selection, it triggers the mode change command, but the mode change command doesn't happen fast enough so that the next telemetry update changes the drop down mode back to the original mode which triggers another command to the vehicle to change the mode back to the original state.
A simple solution to this is to check in the watcher function if the desired mode is already the mode of the vehicle if so, we know that the state change is due to a telemetry update and not from the user.