Change WebM duration fix library #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a problem on the video backend, that is already solved there, so we don't need this solution anymore (and in fact, it was not working properly).
rafaellehmkuhl
requested review from
patrickelectric,
joaoantoniocardoso and
ArturoManzoli
|
CI is failing on Flatpak installation, which is fixed on #853. |
patrickelectric
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the problem was in the library we were using. The new one is based on the bigger ts-ebml project, which is actively developed and appear to deal much better with larger files (they explicitly brag about that).
Successfully tested with a 1 hour/4GB recording.
Fix #794.