Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie vehicles to joystick profiles #857

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Apr 4, 2024

  • Allows assigning different vehicle types to a joystick mapping
  • Auto-set joystick mapping on boot based on vehicle type

Fix #858
Fix #859

@rafaellehmkuhl rafaellehmkuhl force-pushed the tie-vehicles-to-joystick-profiles branch 2 times, most recently from 1ea208e to 5facd87 Compare April 4, 2024 21:37
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review April 4, 2024 21:38
@rafaellehmkuhl rafaellehmkuhl requested a review from a team April 4, 2024 21:38
@rafaellehmkuhl
Copy link
Member Author

@patrickelectric @ArturoManzoli could you take a look at this one to see if it's working properly? If so I will add it to a Beta14 release today.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be free to merge it

@rafaellehmkuhl
Copy link
Member Author

Be free to merge it

Have you tested it?

@patrickelectric
Copy link
Member

Be free to merge it

Have you tested it?

I'm in a meeting right now, can test it tomorrow. Codewise looks good.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow all widgets are now missing and I can't open the configuration menu:

image

image

@rafaellehmkuhl rafaellehmkuhl force-pushed the tie-vehicles-to-joystick-profiles branch from 5facd87 to 15b84d2 Compare April 9, 2024 20:01
@rafaellehmkuhl
Copy link
Member Author

Somehow all widgets are now missing and I can't open the configuration menu

That's strange.
There's no change to any widget logic whatsoever, and I'm testing with @JoaoMario109 right now and everything went fine.

Are you sure you're on the right branch?

Copy link
Contributor

@JoaoMario109 JoaoMario109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to be fine, only await @patrickelectric clarify about the bug that happened in prior comment.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested in my laptop and it's working fine. Not sure what happened on my desktop though, will check tomorrow

@patrickelectric patrickelectric merged commit b4689e4 into bluerobotics:master Apr 10, 2024
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the tie-vehicles-to-joystick-profiles branch April 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants