Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallbacks: Compatibilize style of browser and settings fallback banners #907

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Apr 24, 2024

Also, only show "clear settings" fallback after the user agreed to proceed with the browser check, as they are different situations that shouldn't be shown together, to not confuse the user.

Kapture.2024-04-24.at.14.56.54.mp4

Fix #906

@patrickelectric patrickelectric merged commit 31ce316 into bluerobotics:master Apr 25, 2024
9 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the fix-reset-button-position branch April 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reset cockpit settings" button is over the "proceed anyway" button on unsupported browsers
3 participants